Remove content::URLFetcherDelegate

Remove content::URLFetcherDelegate

Change all references to net::URLFetcherDelegate.

Change some instances of content::URLFetcher to net::URLFetcher as
needed.

Remove unused files auth_response_handler.*.

BUG=118220
TEST=
TBR=sky@chromium.org,joi@chromium.org,mnissler@chromium.org,rlp@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138384

[akalin, 2012-05-22 02:45:00]

+wtc for review

This change is completely mechanical.

[jochen (gone - plz use gerrit), 2012-05-22 07:26:56]

content/ looks good

[wtc, 2012-05-22 17:26:38]

Patch set 1 LGTM.  Just some minor questions and nits below.

https://chromiumcodereview.appspot.com/10392192/diff/1/chrome/browser/alterna...
File chrome/browser/alternate_nav_url_fetcher.h (right):

https://chromiumcodereview.appspot.com/10392192/diff/1/chrome/browser/alterna...
chrome/browser/alternate_nav_url_fetcher.h:22: class URLFetcher;

net/url_request/url_fetcher_delegate.h contains a forward
declaration of URLFetcher.  I'm wondering if we can simply
depend on that, or is it better to explicitly declare what
we need?

https://chromiumcodereview.appspot.com/10392192/diff/1/chrome/browser/alterna...
chrome/browser/alternate_nav_url_fetcher.h:83: scoped_ptr<net::URLFetcher>
fetcher_;

I guess your policy is that we should use net::URLFetcher
instead of content::URLFetcher whenever we can, right?

https://chromiumcodereview.appspot.com/10392192/diff/1/chrome/browser/net/gai...
File chrome/browser/net/gaia/gaia_oauth_fetcher.h (right):

https://chromiumcodereview.appspot.com/10392192/diff/1/chrome/browser/net/gai...
chrome/browser/net/gaia/gaia_oauth_fetcher.h:26: class URLRequestContextGetter;

Should we forward declare URLFetcher here?

https://chromiumcodereview.appspot.com/10392192/diff/1/chrome/browser/safe_br...
File chrome/browser/safe_browsing/protocol_manager.h (right):

https://chromiumcodereview.appspot.com/10392192/diff/1/chrome/browser/safe_br...
chrome/browser/safe_browsing/protocol_manager.h:45: }  // namespace net

Move this up, because net::URLFetcher is already used  on
line 36.

https://chromiumcodereview.appspot.com/10392192/diff/1/chrome/browser/ui/inte...
File chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc
(right):

https://chromiumcodereview.appspot.com/10392192/diff/1/chrome/browser/ui/inte...
chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc:12:
#include "base/stringprintf.h"

On Linux, the "ls" command lists string_util.h after
stringprintf.h, even though '_' is before the lowercase
letters in the ASCII table.  Do you know why?  Just curious.

https://chromiumcodereview.appspot.com/10392192/diff/1/chrome/browser/ui/webu...
File chrome/browser/ui/webui/ntp/suggestions_source_discovery.h (right):

https://chromiumcodereview.appspot.com/10392192/diff/1/chrome/browser/ui/webu...
chrome/browser/ui/webui/ntp/suggestions_source_discovery.h:18: class URLFetcher;

Should we delete this forward declaration?

https://chromiumcodereview.appspot.com/10392192/diff/1/chrome/common/net/gaia...
File chrome/common/net/gaia/oauth2_access_token_fetcher.cc (right):

https://chromiumcodereview.appspot.com/10392192/diff/1/chrome/common/net/gaia...
chrome/common/net/gaia/oauth2_access_token_fetcher.cc:23: using
content::URLFetcher;

This file uses a mixture of content::URLFetcher (elided as
URLFetcher) and net::URLFetcher.  Is that intentional?

Note: several other files have the same (potential) issue.

https://chromiumcodereview.appspot.com/10392192/diff/1/chrome/common/net/gaia...
chrome/common/net/gaia/oauth2_access_token_fetcher.cc:24: using
net::URLFetcherDelegate;

Nit: sort this?

Note: several other files have the same issue.

[akalin, 2012-05-22 21:07:05]

Addressed all comments.

Committing after trybots pass.

TBRing everyone else.

http://codereview.chromium.org/10392192/diff/1/chrome/browser/alternate_nav_u...
File chrome/browser/alternate_nav_url_fetcher.h (right):

http://codereview.chromium.org/10392192/diff/1/chrome/browser/alternate_nav_u...
chrome/browser/alternate_nav_url_fetcher.h:22: class URLFetcher;
On 2012/05/22 17:26:38, wtc wrote:
> 
> net/url_request/url_fetcher_delegate.h contains a forward
> declaration of URLFetcher.  I'm wondering if we can simply
> depend on that, or is it better to explicitly declare what
> we need?

I prefer to explicitly declare, unless the only use URLFetcher is in the type
signatures of the URLFetcherDelegate.

I also did this to clean up the errant non-namespaced URLFetcher
forward-declarations.

http://codereview.chromium.org/10392192/diff/1/chrome/browser/alternate_nav_u...
chrome/browser/alternate_nav_url_fetcher.h:83: scoped_ptr<net::URLFetcher>
fetcher_;
On 2012/05/22 17:26:38, wtc wrote:
> 
> I guess your policy is that we should use net::URLFetcher
> instead of content::URLFetcher whenever we can, right?

Sure, although it'll be moot soon; I will remove content::URLFetcher in my next
CL.

http://codereview.chromium.org/10392192/diff/1/chrome/browser/net/gaia/gaia_o...
File chrome/browser/net/gaia/gaia_oauth_fetcher.h (right):

http://codereview.chromium.org/10392192/diff/1/chrome/browser/net/gaia/gaia_o...
chrome/browser/net/gaia/gaia_oauth_fetcher.h:26: class URLRequestContextGetter;
On 2012/05/22 17:26:38, wtc wrote:
> 
> Should we forward declare URLFetcher here?

Done.

http://codereview.chromium.org/10392192/diff/1/chrome/browser/safe_browsing/p...
File chrome/browser/safe_browsing/protocol_manager.h (right):

http://codereview.chromium.org/10392192/diff/1/chrome/browser/safe_browsing/p...
chrome/browser/safe_browsing/protocol_manager.h:45: }  // namespace net
On 2012/05/22 17:26:38, wtc wrote:
> 
> Move this up, because net::URLFetcher is already used  on
> line 36.

Done.

http://codereview.chromium.org/10392192/diff/1/chrome/browser/ui/intents/web_...
File chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc
(right):

http://codereview.chromium.org/10392192/diff/1/chrome/browser/ui/intents/web_...
chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc:12:
#include "base/stringprintf.h"
On 2012/05/22 17:26:38, wtc wrote:
> 
> On Linux, the "ls" command lists string_util.h after
> stringprintf.h, even though '_' is before the lowercase
> letters in the ASCII table.  Do you know why?  Just curious.

I don't -- that's curious.  Perhaps pre-existing tradition before ASCII? :)

http://codereview.chromium.org/10392192/diff/1/chrome/browser/ui/webui/ntp/su...
File chrome/browser/ui/webui/ntp/suggestions_source_discovery.h (right):

http://codereview.chromium.org/10392192/diff/1/chrome/browser/ui/webui/ntp/su...
chrome/browser/ui/webui/ntp/suggestions_source_discovery.h:18: class URLFetcher;
On 2012/05/22 17:26:38, wtc wrote:
> 
> Should we delete this forward declaration?

Done.

http://codereview.chromium.org/10392192/diff/1/chrome/common/net/gaia/oauth2_...
File chrome/common/net/gaia/oauth2_access_token_fetcher.cc (right):

http://codereview.chromium.org/10392192/diff/1/chrome/common/net/gaia/oauth2_...
chrome/common/net/gaia/oauth2_access_token_fetcher.cc:23: using
content::URLFetcher;
On 2012/05/22 17:26:38, wtc wrote:
> 
> This file uses a mixture of content::URLFetcher (elided as
> URLFetcher) and net::URLFetcher.  Is that intentional?
> 
> Note: several other files have the same (potential) issue.

Not intentional, but it's harmless (since I'll remove content::URLFetcher in a
future CL).

Fixed it here (and others) anyway.

http://codereview.chromium.org/10392192/diff/1/chrome/common/net/gaia/oauth2_...
chrome/common/net/gaia/oauth2_access_token_fetcher.cc:24: using
net::URLFetcherDelegate;
On 2012/05/22 17:26:38, wtc wrote:
> 
> Nit: sort this?
> 
> Note: several other files have the same issue.

Done, sorted other files, too.

[commit-bot: I haz the power, 2012-05-22 21:11:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10392192/5005

[commit-bot: I haz the power, 2012-05-22 21:41:21]

Try job failure for 10392192-5005 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...