Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/google/google_url_tracker.cc

Issue 10392189: Fix unsafe attempt to blindly access owner() in GoogleURLTracker::Close(). (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/google/google_url_tracker.cc
===================================================================
--- chrome/browser/google/google_url_tracker.cc (revision 137999)
+++ chrome/browser/google/google_url_tracker.cc (working copy)
@@ -103,7 +103,7 @@
}
void GoogleURLTrackerInfoBarDelegate::Close(bool redo_search) {
- if (redo_search) {
+ if (redo_search && owner()) {
// Re-do the user's search on the new domain.
url_canon::Replacements<char> replacements;
const std::string& host(new_google_url_.host());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698