Issue 10392189: Fix unsafe attempt to blindly access owner() in GoogleURLTracker::Close().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10392189: Fix unsafe attempt to blindly access owner() in GoogleURLTracker::Close(). (Closed)

Created:
8 years, 7 months ago by Peter Kasting

Modified:
8 years, 7 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix unsafe attempt to blindly access owner() in GoogleURLTracker::Close(). This was introduced by r135054, which moved some code that derefed owner() up above the check to see whether it was NULL. BUG=128714 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138187

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/google/google_url_tracker.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

8 years, 7 months ago (2012-05-21 22:45:24 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkasting@chromium.org/10392189/1

Expand Messages | Collapse Messages