Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2908)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/threading/thread.cc

Issue 10392188: Base: Fix a race settin the running_ flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/thread.cc
===================================================================
--- base/threading/thread.cc (revision 138119)
+++ base/threading/thread.cc (working copy)
@@ -161,11 +161,11 @@
// Let's do this before signaling we are started.
Init();
+ running_ = true;
startup_data_->event.Signal();
// startup_data_ can't be touched anymore since the starting thread is now
// unlocked.
- running_ = true;
Run(message_loop_);
running_ = false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698