Issue 10392188: Base: Fix a race settin the running_ flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10392188: Base: Fix a race settin the running_ flag. (Closed)

Created:
8 years, 7 months ago by rvargas (doing something else)

Modified:
8 years, 7 months ago

Reviewers:
James Hawkins, willchan no longer on Chromium

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Base: Fix a race settin the running_ flag. BUG=127931 TEST=green bots TBR=jhawkins, willchan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138143

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/threading/thread.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

8 years, 7 months ago (2012-05-21 21:34:41 UTC) #3

lgtm

On Mon, May 21, 2012 at 2:31 PM, <rvargas@chromium.org> wrote:

> Reviewers: willchan, James Hawkins,
>
> Description:
> Base: Fix a race settin the running_ flag.
>
> BUG=127931
> TEST=green bots
> TBR=jhawkins, willchan
>
> Please review this at
https://chromiumcodereview.**appspot.com/10392188/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     base/threading/thread.cc
>
>
> Index: base/threading/thread.cc
> ==============================**==============================**=======
> --- base/threading/thread.cc    (revision 138119)
> +++ base/threading/thread.cc    (working copy)
> @@ -161,11 +161,11 @@
>     // Let's do this before signaling we are started.
>     Init();
>
> +    running_ = true;
>     startup_data_->event.Signal();
>     // startup_data_ can't be touched anymore since the starting thread is
> now
>     // unlocked.
>
> -    running_ = true;
>     Run(message_loop_);
>     running_ = false;
>
>
>
>

Expand Messages | Collapse Messages