Issue 10392184: Fix possible crash in FinalizeInstantQuery() if AddMatchToMap() fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10392184: Fix possible crash in FinalizeInstantQuery() if AddMatchToMap() fails. (Closed)

Created:
8 years, 7 months ago by Peter Kasting

Modified:
8 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, James Su

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix possible crash in FinalizeInstantQuery() if AddMatchToMap() fails. It's not clear to me why this is happening frequently. This should only fail if there is no default provider, but if that's true how are we doing instant? ...Whatever. BUG=128575 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138135

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	chrome/browser/autocomplete/search_provider.cc	View		3 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages