Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: chrome/browser/extensions/api/serial/serial_connection.h

Issue 10392181: Implement serial API for Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: OSX/Win fixes and review feedback. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/serial/serial_connection.h
diff --git a/chrome/browser/extensions/api/serial/serial_connection.h b/chrome/browser/extensions/api/serial/serial_connection.h
index 372c34ce452ca52a8de23e3338a4eae7a927181f..42628b3e71fe3995fc6d01b1de36f621ee243281 100644
--- a/chrome/browser/extensions/api/serial/serial_connection.h
+++ b/chrome/browser/extensions/api/serial/serial_connection.h
@@ -10,6 +10,7 @@
#include <string>
#include "base/memory/ref_counted.h"
+#include "base/platform_file.h"
#include "chrome/browser/extensions/api/api_resource.h"
#include "net/base/io_buffer.h"
@@ -33,9 +34,13 @@ class SerialConnection : public APIResource {
int Read(uint8* byte);
int Write(scoped_refptr<net::IOBuffer> io_buffer, int byte_count);
+ protected:
+ // Do platform-specific work after a successful Open().
+ bool PostOpen();
+
private:
std::string port_;
- int fd_;
+ base::PlatformFile file_;
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698