chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc - Issue 10392181: Implement serial API for Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc

Issue 10392181: Implement serial API for Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: TerminalDevice -> FromCurrentPos Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/platform_file.h ('K') | « chrome/browser/extensions/api/serial/serial_connection_win.cc ('k') | chrome/browser/extensions/api/serial/serial_port_enumerator_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc

diff --git a/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc b/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc

index 42fdc37aab3b11ca73e99ad55485cb39e2c992ef..c069ebb2b976100f9fc2a441ffee8e5ea046e67a 100644

--- a/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc

+++ b/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc

@@ -81,7 +81,7 @@ SerialPortEnumerator::GenerateValidSerialPortNames() {

if (next_device.empty())

break;

- std::set<std::string>::const_iterator i = valid_patterns.begin();

+ StringSet::const_iterator i = valid_patterns.begin();

for (; i != valid_patterns.end(); ++i) {

if (MatchPattern(next_device, *i)) {

name_set.insert(next_device);