Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7633)

Unified Diff: chrome/common/extensions/api/experimental_serial.idl

Issue 10392181: Implement serial API for Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: From -> At. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/experimental_serial.idl
diff --git a/chrome/common/extensions/api/experimental_serial.idl b/chrome/common/extensions/api/experimental_serial.idl
index dab964319d09fa1b8cd5ac31c562c9a1cef6b337..c355467e57b89dc05d88db77099e10c57ca80163 100644
--- a/chrome/common/extensions/api/experimental_serial.idl
+++ b/chrome/common/extensions/api/experimental_serial.idl
@@ -21,10 +21,8 @@
// The number of bytes received, or a negative number if an error occurred.
long bytesRead;
- // The data received. Warning: will probably become a blob or other
- // appropriate binary-friendly type.
- // TODO(miket): [instanceOf=ArrayBuffer]object data;
- long[] data;
+ // The data received.
+ ArrayBuffer data;
};
callback ReadCallback = void (ReadInfo readInfo);
@@ -66,10 +64,8 @@
// |connectionId| : The id of the connection.
// |data| : The string to write.
// |callback| : Called when the string has been written.
- //
- // TODO(miket): [instanceOf=ArrayBuffer]object data;
static void write(long connectionId,
- long[] data,
+ ArrayBuffer data,
WriteCallback callback);
};
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/test/data/extensions/api_test/serial/api/background.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698