Issue 10392177: views: Fix the button's label of the question message box.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10392177: views: Fix the button's label of the question message box. (Closed)

Created:
8 years, 7 months ago by tfarina

Modified:
8 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Fix the button's label of the question message box. They should read Yes/No, instead of OK/Close. BUG=128861 TEST=to reproduce this, have more than 15 bookmarks in a folder in the bookmark bar, click on "Open All Bookmarks", you should see a confirmation dialog with [Yes] [No] buttons. R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138121

Patch Set 1 #

Patch Set 2 : add return only OK for the other two cases #

Patch Set 3 : revert the condition in GetDialogButtons - simplifies. #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	chrome/browser/ui/views/simple_message_box_views.cc	View	1 2	1 chunk	+9 lines, -6 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tfarina

http://codereview.chromium.org/10392177/diff/9002/chrome/browser/ui/views/simple_message_box_views.cc File chrome/browser/ui/views/simple_message_box_views.cc (right): http://codereview.chromium.org/10392177/diff/9002/chrome/browser/ui/views/simple_message_box_views.cc#newcode166 chrome/browser/ui/views/simple_message_box_views.cc:166: IDS_CONFIRM_MESSAGEBOX_YES_BUTTON_LABEL : we could have an IDS_YES and IDS_NO.

8 years, 7 months ago (2012-05-19 14:05:01 UTC) #2

Peter Kasting

8 years, 7 months ago (2012-05-21 18:06:20 UTC) #3

LGTM, but as I noted on the bug, generic labels are basically always bad; we
should really always use custom labels that match the question being asked.

Expand Messages | Collapse Messages