Zygote: create variables for magic fd numbers

Zygote: create variables for magic fd numbers

The magic number "7" was used across source files to denote the file
descriptor for the dummy fd.

BUG=None
TEST=None
NOTRY=true


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138269

[jln (very slow on Chromium), 2012-05-19 04:31:25]

Hi Brett,

I've lost a lot of time tracking a bug because of this magic.
This should be cleaner.

Julien

[brettw, 2012-05-21 17:52:05]

lgtm

https://chromiumcodereview.appspot.com/10392176/diff/5001/content/zygote/zygo...
File content/zygote/zygote_linux.cc (right):

https://chromiumcodereview.appspot.com/10392176/diff/5001/content/zygote/zygo...
content/zygote/zygote_linux.cc:414: close(content::kZygoteIdFd);  // Another
socket from the browser.
You're already in content, so remove "content::".

[commit-bot: I haz the power, 2012-05-21 18:10:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/10392176/6004

[commit-bot: I haz the power, 2012-05-21 22:28:54]

Try job failure for 10392176-6004 (retry) (retry) on win_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-05-22 00:45:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/10392176/6004

[commit-bot: I haz the power, 2012-05-22 04:23:19]

Try job failure for 10392176-6004 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-05-22 04:29:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/10392176/6004

[commit-bot: I haz the power, 2012-05-22 09:01:16]

Try job failure for 10392176-6004 (retry) (retry) on win_rel for steps
"base_unittests, sync_unit_tests".
It's a second try, previously, steps "base_unittests, browser_tests,
sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-05-22 16:22:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/10392176/6004

[commit-bot: I haz the power, 2012-05-22 16:23:55]

Change committed as 138269