Issue 10392173: Flash window by pulsing their launcher icon state indicator

Issue 10392173: Flash window by pulsing their launcher icon state indicator (Closed)

Created:
8 years, 7 months ago by DaveMoore

Modified:
8 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Flash window by pulsing their launcher icon state indicator BUG=119965 TEST=BrowserLauncherItemControllerTest.FlashWindow Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137993

Patch Set 3 : copyright #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -12 lines)			Patch
M	ash/launcher/launcher_button.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.h	View	1	4 chunks	+12 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.cc	View	1	4 chunks	+27 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller_unittest.cc	View		2 chunks	+27 lines, -0 lines	0 comments	Download
M	ui/aura/client/aura_constants.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/aura/client/aura_constants.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/animation/throb_animation.h	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/base/animation/throb_animation.cc	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download
M	ui/views/widget/native_widget_aura.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

https://chromiumcodereview.appspot.com/10392173/diff/2001/chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.cc File chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.cc (right): https://chromiumcodereview.appspot.com/10392173/diff/2001/chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.cc#newcode41 chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.cc:41: window_->AddObserver(this); We're going to want to support this for ...

8 years, 7 months ago (2012-05-18 22:29:42 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/10392173/8001

8 years, 7 months ago (2012-05-18 22:36:34 UTC) #4

Change committed as 137993

Expand Messages | Collapse Messages