Issue 10392158: Correctly check for native error objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10392158: Correctly check for native error objects. (Closed)

Created:
8 years, 7 months ago by Yang

Modified:
8 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Correctly check for native error objects. BUG=2138 TEST= Committed: https://code.google.com/p/v8/source/detail?r=11589

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -11 lines)			Patch
	M	src/messages.js	View		1 chunk	+14 lines, -11 lines	0 comments	Download

Total messages: 2 (0 generated)

arv (Not doing code reviews)

8 years, 7 months ago (2012-05-18 17:07:11 UTC) #2

LGTM


Thanks.

It would have been good have some tests for this. I'm not sure how you test what
is in the v8::Message object though?