Fixing race condition in prepearing thumbnails for the bottom panel.

Fixing race condition in prepearing thumbnails for the bottom panel.

Instead of adding the enlarged thumbnail then image loaded empty hidden div is created.

BUG=128254
TEST=To simulate situation then new images replace old ones before firsts have completely loaded execute "FileManager.THUMBNAIL_SHOW_DELAY = 1" in DevTools.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137857

[Vladislav Kaznacheev, 2012-05-18 06:58:56]

https://chromiumcodereview.appspot.com/10392155/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10392155/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_manager.js:2256: return;
if we return here the the DIV will be empty. Will it still show up on hover?

[Vladislav Kaznacheev, 2012-05-18 06:59:35]

https://chromiumcodereview.appspot.com/10392155/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10392155/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_manager.js:2310: return
largeImageBox;
return is not required anymore

[SeRya, 2012-05-18 09:19:37]

https://chromiumcodereview.appspot.com/10392155/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10392155/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_manager.js:2256: return;
On 2012/05/18 06:58:57, Vladislav Kaznacheev wrote:
> if we return here the the DIV will be empty. Will it still show up on hover?

It doesn't show up. However thumbnails used to hide and it was wrong. Fixed.

Thanks for the catch.

https://chromiumcodereview.appspot.com/10392155/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_manager.js:2310: return
largeImageBox;
On 2012/05/18 06:59:35, Vladislav Kaznacheev wrote:
> return is not required anymore

Done.

[Vladislav Kaznacheev, 2012-05-18 11:43:39]

https://chromiumcodereview.appspot.com/10392155/diff/4004/chrome/browser/reso...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10392155/diff/4004/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:2160: zoomed.hidden =
true;
Do we need both |hidden| attribute and |has-zoom| class? They seem to be in
sync.

https://chromiumcodereview.appspot.com/10392155/diff/4004/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:2263: * @return
{boolean} True if zoomed image presents.
presents -> is present

[SeRya, 2012-05-18 12:06:07]

https://chromiumcodereview.appspot.com/10392155/diff/4004/chrome/browser/reso...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10392155/diff/4004/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:2160: zoomed.hidden =
true;
On 2012/05/18 11:43:40, Vladislav Kaznacheev wrote:
> Do we need both |hidden| attribute and |has-zoom| class? They seem to be in
> sync.

If we only play with the class it triggers animation. It cause flickering on
each selection change. hidden = false suppress the animation.

https://chromiumcodereview.appspot.com/10392155/diff/4004/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:2263: * @return
{boolean} True if zoomed image presents.
On 2012/05/18 11:43:40, Vladislav Kaznacheev wrote:
> presents -> is present

Done.

[Vladislav Kaznacheev, 2012-05-18 12:19:21]

lgtm

[commit-bot: I haz the power, 2012-05-18 12:21:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/serya@chromium.org/10392155/11001

[commit-bot: I haz the power, 2012-05-18 13:49:33]

Change committed as 137857