Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h

Issue 10392152: RefCounted types should not have public destructors, Linux fixes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h
diff --git a/chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h b/chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h
index 1e4ded2bf7f10b5b4b2b6d67054dd7198a0ceefa..01de16c1076efc2dbf1bff9245fa48602c09ffde 100644
--- a/chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h
+++ b/chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h
@@ -85,12 +85,13 @@ class CreateWebApplicationShortcutsDialogGtk
CreateWebApplicationShortcutsDialogGtk(GtkWindow* parent,
TabContentsWrapper* tab_contents);
- virtual ~CreateWebApplicationShortcutsDialogGtk() {}
virtual void OnCreatedShortcut(void) OVERRIDE;
- private:
+ protected:
+ virtual ~CreateWebApplicationShortcutsDialogGtk() {}
+ private:
// TabContentsWrapper for which the shortcut will be created.
TabContentsWrapper* tab_contents_;
@@ -107,7 +108,6 @@ class CreateChromeApplicationShortcutsDialogGtk
CreateChromeApplicationShortcutsDialogGtk(GtkWindow* parent,
Profile* profile,
const Extension* app);
- virtual ~CreateChromeApplicationShortcutsDialogGtk() {}
// Implement ImageLoadingTracker::Observer. |tracker_| is used to
// load the app's icon. This method recieves the icon, and adds
@@ -117,6 +117,8 @@ class CreateChromeApplicationShortcutsDialogGtk
int index) OVERRIDE;
protected:
+ virtual ~CreateChromeApplicationShortcutsDialogGtk() {}
+
virtual void CreateDesktopShortcut(
const ShellIntegration::ShortcutInfo& shortcut_info) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698