Issue 10392150: Remove %_SwapElements. This inlined runtime contained an optimization that was dangerous in the pr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10392150: Remove %_SwapElements. This inlined runtime contained an optimization that was dangerous in the pr… (Closed)

Created:
8 years, 7 months ago by Erik Corry

Modified:
8 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium), fschneider, Florian Schneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Remove %_SwapElements. This inlined runtime contained an optimization that was dangerous in the presence of incremental compaction. It also prevented QuickSort from array.js from being optimized by Crankshaft, so it is probably better to do without it. We have high hopes that this will fix bug=117879 . Committed: https://code.google.com/p/v8/source/detail?r=11588

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+8 lines, -429 lines)			Patch
src/arm/full-codegen-arm.cc	View	1 chunk	+0 lines, -98 lines	0 comments	Download
src/array.js	View	2 chunks	+7 lines, -3 lines	0 comments	Download
src/hydrogen.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
src/ia32/full-codegen-ia32.cc	View	1 chunk	+0 lines, -93 lines	0 comments	Download
src/mips/full-codegen-mips.cc	View	1 chunk	+0 lines, -98 lines	0 comments	Download
src/runtime.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
src/runtime.cc	View	1 chunk	+0 lines, -30 lines	0 comments	Download
src/x64/full-codegen-x64.cc	View	1 chunk	+0 lines, -96 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM Please refer to the bug with BUG=

8 years, 7 months ago (2012-05-17 20:03:31 UTC) #2

STV!

Expand Messages | Collapse Messages