Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 10392142: Revert 137630 - Broke ASAN (Closed)

Created:
8 years, 7 months ago by Ryan Sleevi
Modified:
8 years, 7 months ago
CC:
chromium-reviews, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org, Aaron Boodman, ajwong+watch_chromium.org
Visibility:
Public.

Description

Revert 137630 - Broke ASAN Only return the visible page actions from PageActionController. This is a bit of a yak shave to support having the "action box" show active extensions on the current page rather than page actions. Previously, PageActionController was creating widgets for everything then LocationBarViewGtk was hiding them as necessary. This is assumes too much; we need to push the visibility logic into the Controller for the future. BUG=127988 Review URL: https://chromiumcodereview.appspot.com/10388160 TBR=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -229 lines) Patch
M chrome/browser/extensions/action_box_controller.h View 3 chunks +18 lines, -8 lines 0 comments Download
D chrome/browser/extensions/action_box_controller.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/extensions/execute_code_in_tab_function.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tab_helper.h View 6 chunks +0 lines, -33 lines 0 comments Download
M chrome/browser/extensions/extension_tab_helper.cc View 4 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/page_action_controller.h View 2 chunks +4 lines, -17 lines 0 comments Download
M chrome/browser/extensions/page_action_controller.cc View 2 chunks +14 lines, -39 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.h View 6 chunks +16 lines, -10 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 12 chunks +87 lines, -72 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.h View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_notification_types.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/extension_action.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Ryan Sleevi
8 years, 7 months ago (2012-05-17 05:13:35 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698