Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 10392136: Add WebFrame pointer to WebViewClient::startDragging (Closed)

Created:
8 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Add WebFrame pointer to WebViewClient::startDragging BUG=124750 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M content/renderer/render_view_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/plugins/webview_plugin.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/plugins/webview_plugin.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
webkit side is here: https://bugs.webkit.org/show_bug.cgi?id=86670
8 years, 7 months ago (2012-05-16 20:53:16 UTC) #1
jochen (gone - plz use gerrit)
Darin, please review
8 years, 7 months ago (2012-05-18 07:37:04 UTC) #2
darin (slow to review)
LGTM
8 years, 7 months ago (2012-05-18 18:42:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10392136/1
8 years, 7 months ago (2012-05-18 18:43:45 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-18 19:51:27 UTC) #5
Change committed as 137932

Powered by Google App Engine
This is Rietveld 408576698