Issue 10392130: Some clean-up of typed array support in d8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10392130: Some clean-up of typed array support in d8. (Closed)

Created:
8 years, 7 months ago by rossberg

Modified:
8 years, 6 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Some clean-up of typed array support in d8. R=yangguo@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11679

Patch Set 1 #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -72 lines)			Patch
	M	src/d8.cc	View		1 chunk	+49 lines, -72 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with comment. And maybe add a test? https://chromiumcodereview.appspot.com/10392130/diff/1/src/d8.cc File src/d8.cc (right): https://chromiumcodereview.appspot.com/10392130/diff/1/src/d8.cc#newcode360 src/d8.cc:360: array->Set(String::New(kArrayBufferMarkerPropName), ...

8 years, 7 months ago (2012-05-18 12:10:40 UTC) #2

rossberg

8 years, 6 months ago (2012-05-30 13:37:15 UTC) #3

https://chromiumcodereview.appspot.com/10392130/diff/1/src/d8.cc
File src/d8.cc (right):

https://chromiumcodereview.appspot.com/10392130/diff/1/src/d8.cc#newcode360
src/d8.cc:360: array->Set(String::New(kArrayBufferMarkerPropName), True(),
ReadOnly);
On 2012/05/18 12:10:40, Yang wrote:
> Is the property _is_array_buffer_ something that is supposed to be exposed?
You
> could use SetHiddenValue instead.
> 
> Same goes for _array_buffer_ref_.

Done. _array_buffer_ref_ actually is redundant. Cleaned up the whole
finalization mess in a separate CL.

Expand Messages | Collapse Messages