Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 10392128: Upstream Geolocation timestamp fix. (Closed)

Created:
8 years, 7 months ago by John Knottenbelt
Modified:
8 years, 7 months ago
Reviewers:
bulach
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Upstream Geolocation timestamp fix. We need to pass the timestamp as a double rather than as a long to avoid overflow. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M content/browser/geolocation/location_api_adapter_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/location_api_adapter_android.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/android/java/org/chromium/content/browser/LocationProvider.java View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
John Knottenbelt
8 years, 7 months ago (2012-05-16 13:26:35 UTC) #1
bulach
lgtm thanks!
8 years, 7 months ago (2012-05-16 13:28:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/10392128/1
8 years, 7 months ago (2012-05-16 15:08:31 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-16 16:28:50 UTC) #4
Change committed as 137438

Powered by Google App Engine
This is Rietveld 408576698