Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10392116: [Sync] Associate UI datatypes before non-UI datatypes. (Closed)

Created:
8 years, 7 months ago by Nicolas Zea
Modified:
8 years, 7 months ago
Reviewers:
lipalani1
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

[Sync] Associate UI datatypes before non-UI datatypes. BUG=128213 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138862

Patch Set 1 #

Patch Set 2 : Maintain order #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/sync/glue/model_association_manager.cc View 1 2 3 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Nicolas Zea
PTAL
8 years, 7 months ago (2012-05-15 20:09:11 UTC) #1
Nicolas Zea
ping!
8 years, 7 months ago (2012-05-16 21:54:53 UTC) #2
lipalani1
LGTM
8 years, 7 months ago (2012-05-16 22:13:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/10392116/4001
8 years, 7 months ago (2012-05-16 22:16:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/10392116/4001
8 years, 7 months ago (2012-05-23 18:50:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/10392116/4001
8 years, 7 months ago (2012-05-24 17:37:49 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/browser/sync/glue/data_type_manager_impl.cc: While running patch -p1 --forward --force; patching file chrome/browser/sync/glue/data_type_manager_impl.cc ...
8 years, 7 months ago (2012-05-24 17:37:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/10392116/20001
8 years, 7 months ago (2012-05-24 17:55:58 UTC) #8
commit-bot: I haz the power
Failed to apply patch for chrome/browser/sync/glue/data_type_manager_impl.cc: While running patch -p1 --forward --force; patching file chrome/browser/sync/glue/data_type_manager_impl.cc ...
8 years, 7 months ago (2012-05-24 17:56:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/10392116/24001
8 years, 7 months ago (2012-05-24 18:01:11 UTC) #10
commit-bot: I haz the power
8 years, 7 months ago (2012-05-24 19:35:12 UTC) #11 
Change committed as 138862

Powered by Google App Engine
This is Rietveld 408576698