Issue 10392109: Write to NULL will trigger a Clang compile warning and the compiler may

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10392109: Write to NULL will trigger a Clang compile warning and the compiler may (Closed)

Created:
8 years, 7 months ago by kaiwang

Modified:
8 years, 7 months ago

Reviewers:
hans

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Write to NULL will trigger a Clang compile warning and the compiler may optimize and turn it into a non-op. int* -> volatile int* to fix this. BUG=127724 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137251

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/tcmalloc/chromium/src/base/abort.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/10392109/1

8 years, 7 months ago (2012-05-15 18:41:28 UTC) #3

Change committed as 137251