Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: chrome/browser/ui/cocoa/base_bubble_controller.h

Issue 10392108: Only close popup bubble when a tab switch happens. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/base_bubble_controller.h
diff --git a/chrome/browser/ui/cocoa/base_bubble_controller.h b/chrome/browser/ui/cocoa/base_bubble_controller.h
index 46b1de1831f7efb22faad91b5587612b4e6c055e..12a438c1cd5030b953b90a5627994007d2dfe38b 100644
--- a/chrome/browser/ui/cocoa/base_bubble_controller.h
+++ b/chrome/browser/ui/cocoa/base_bubble_controller.h
@@ -7,11 +7,8 @@
#import "base/mac/cocoa_protocols.h"
#include "base/memory/scoped_ptr.h"
-namespace BaseBubbleControllerInternal {
-class Bridge;
-}
-
@class InfoBubbleView;
+class TabStripModelObserverBridge;
// Base class for bubble controllers. Manages a xib that contains an
// InfoBubbleWindow which contains an InfoBubbleView. Contains code to close
@@ -29,8 +26,8 @@ class Bridge;
NSWindow* parentWindow_; // weak
NSPoint anchor_;
IBOutlet InfoBubbleView* bubble_; // to set arrow position
- // Bridge that listens for notifications.
- scoped_ptr<BaseBubbleControllerInternal::Bridge> baseBridge_;
+ // Bridge for tab change notifications.
+ scoped_ptr<TabStripModelObserverBridge> tabStripObserverBridge_;
// Non-nil only on 10.7+. Both weak, owned by AppKit.
// A local event tap that will dismiss the bubble when a click is delivered
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/base_bubble_controller.mm » ('j') | chrome/browser/ui/cocoa/base_bubble_controller.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698