Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10392105: Make ASAN options apply to target binaries only (Closed)

Created:
8 years, 7 months ago by glotov
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Make ASAN options apply to target binaries only BUG=none TEST=unit Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137416

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M build/common.gypi View 1 2 1 chunk +14 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
glotov1
Hi! Probably this should have been done in the beginning, what do you think?
8 years, 7 months ago (2012-05-15 14:19:03 UTC) #1
Nico
Makes sense to me, but glider owns the asan configs.
8 years, 7 months ago (2012-05-15 14:59:53 UTC) #2
Alexander Potapenko
Makes sense to me, too, and may probably save several seconds at build time on ...
8 years, 7 months ago (2012-05-16 11:06:47 UTC) #3
Alexander Potapenko
8 years, 7 months ago (2012-05-16 12:53:28 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698