Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10392097: Prevent showing multiple network config views. (Closed)

Created:
8 years, 7 months ago by stevenjb
Modified:
8 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Prevent showing multiple network config views. BUG=126682 TEST=See issue + ensure failing to connect to a wifi or VPN with bad credentials re-displays the connect dialog. TBR=jhawkins for webui Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -54 lines) Patch
M chrome/browser/chromeos/network_login_observer.cc View 4 chunks +2 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.h View 2 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 5 chunks +71 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 2 chunks +4 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.cc View 5 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stevenjb
Some long overdue cleanup.
8 years, 7 months ago (2012-05-15 01:42:35 UTC) #1
Greg Spencer (Chromium)
lgtm
8 years, 7 months ago (2012-05-16 00:03:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10392097/1
8 years, 7 months ago (2012-05-16 00:07:28 UTC) #3
commit-bot: I haz the power
Presubmit check for 10392097-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-16 00:07:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10392097/1
8 years, 7 months ago (2012-05-16 16:42:22 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-16 18:22:04 UTC) #6 
Change committed as 137461

Powered by Google App Engine
This is Rietveld 408576698