Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 10392096: Makes popups persist across all workspaces. (Closed)

Created:
8 years, 7 months ago by sky
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Makes popups persist across all workspaces. BUG=124088 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/ui/views/frame/browser_frame_aura.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
8 years, 7 months ago (2012-05-15 00:19:01 UTC) #1
Ben Goodger (Google)
I don't think this is something we necessarily want to do. There are plenty of ...
8 years, 7 months ago (2012-05-15 16:05:22 UTC) #2
sky
This doesn't make popups always on top, but rather lets them exist at the same ...
8 years, 7 months ago (2012-05-15 16:10:07 UTC) #3
Ben Goodger (Google)
8 years, 7 months ago (2012-05-15 16:11:36 UTC) #4
ic. LGTM in that case then.

On Tue, May 15, 2012 at 9:10 AM, Scott Violet <sky@chromium.org> wrote:

> This doesn't make popups always on top, but rather lets them exist at
> the same time as a maximized window. So, if you're on a maximized
> window and it creates a popup you'll see both the popup and the
> maximized window. If you click back on the maximized window the popup
> is moved to the back of the z-order with the maximized window on top.
>
>  -Scott
>
> On Tue, May 15, 2012 at 9:05 AM,  <ben@chromium.org> wrote:
> > I don't think this is something we necessarily want to do. There are
> plenty
> > of
> > sites that open instances of themselves in popups... in those cases those
> > sites
> > are not something I want to stick "on top"
> >
> > http://codereview.chromium.org/10392096/
>

Powered by Google App Engine
This is Rietveld 408576698