Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 10392094: Add PathService::Get(chrome::DIR_USER_PICTURES). (Closed)

Created:
8 years, 7 months ago by Lei Zhang
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add PathService::Get(chrome::DIR_USER_PICTURES). BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137596

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix mac #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -5 lines) Patch
M chrome/common/chrome_paths.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_paths.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/chrome_paths_android.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/chrome_paths_internal.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_paths_linux.cc View 1 2 2 chunks +21 lines, -1 line 0 comments Download
M chrome/common/chrome_paths_mac.mm View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/common/chrome_paths_win.cc View 1 2 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
This will be used for Media Gallery. jcivelli: Android csilv: Mac arthurhsu: Win vandebo: the ...
8 years, 7 months ago (2012-05-14 23:25:51 UTC) #1
vandebo (ex-Chrome)
LGTM
8 years, 7 months ago (2012-05-14 23:34:06 UTC) #2
Lei Zhang
Patch set 2 fixes the build on Mac.
8 years, 7 months ago (2012-05-16 07:38:22 UTC) #3
Jay Civelli
lgtm
8 years, 7 months ago (2012-05-16 17:07:03 UTC) #4
csilv
lgtm
8 years, 7 months ago (2012-05-16 18:56:39 UTC) #5
arthurhsu
lgtm lgtm
8 years, 7 months ago (2012-05-16 18:59:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10392094/12001
8 years, 7 months ago (2012-05-16 19:02:51 UTC) #7
commit-bot: I haz the power
Can't apply patch for file chrome/common/chrome_paths.cc. While running patch -p0 --forward --force; patching file chrome/common/chrome_paths.cc ...
8 years, 7 months ago (2012-05-16 21:29:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10392094/13002
8 years, 7 months ago (2012-05-16 23:23:31 UTC) #9
commit-bot: I haz the power
8 years, 7 months ago (2012-05-17 01:07:02 UTC) #10
Change committed as 137596

Powered by Google App Engine
This is Rietveld 408576698