When clicking rapidly 2 different select popups, we could reach a state where

When clicking rapidly 2 different select popups, we could reach a state where
one of the Chrome ExternalPopup object that the RenderView owns gets destroyed
but the Webkit ExternalPopup does not get notified and still keeps a pointer to
the deleted object, causing a crasher later on.
We prevent this kind of scenario by refusing to create a new popup if one is
already showing. WebKit will just cancel that 2nd popup in that case.

BUG=124678
TEST=Open www.vescam.com/select.html On the section with a row of 3 selects,
     try clicking between them rapidly. It should never crash.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139441

[Ilya Sherman, 2012-05-14 23:26:04]

LGTM

https://chromiumcodereview.appspot.com/10392093/diff/1/content/renderer/rende...
File content/renderer/render_view_impl.cc (right):

https://chromiumcodereview.appspot.com/10392093/diff/1/content/renderer/rende...
content/renderer/render_view_impl.cc:1588: // will have to close the first one
before another one can be shown.
nit: Perhaps update this comment to mention that the |extenral_popup_menu_| can
also be non-NULL in case we haven't received the SelectPopupMenuItem message
yet?

[Ilya Sherman, 2012-05-22 23:54:33]

Jay, friendly ping

[Jay Civelli, 2012-05-23 17:44:06]

Sorry, I had forgotten about this.
The associated patch in WebKit did not land.
I just pinged tkent to approve it.
I'll land the chromium part as soon as the WebKit patch has been pulled in.

Jay

On Tue, May 22, 2012 at 4:54 PM, <isherman@chromium.org> wrote:

> Jay, friendly ping
>
>
https://chromiumcodereview.**appspot.com/10392093/<https://chromiumcodereview...
>

[Jay Civelli, 2012-05-29 20:59:56]

Adding jamesr as reviewer for OWNER review.

Thanks.

Jay

[jamesr, 2012-05-29 21:39:14]

lgtm

[commit-bot: I haz the power, 2012-05-29 21:57:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jcivelli@chromium.org/10392093/9001

[commit-bot: I haz the power, 2012-05-30 00:32:41]

Change committed as 139441