Add a new gyp define to be used by the swarm master.

Add a new gyp define to be used by the swarm master.

Rename tests_run to test_isolation_mode.

TBR=mad@chromium.org
BUG=98636
TEST=
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137127

[M-A Ruel, 2012-05-14 01:40:15]

Chris, what do you think about this? Then we could override this value in
chromium.swarm to remove the need to do an additional copy.

I'm still unsatisfied about tests_run and tests_outdir. Maybe isolate_mode and
isolate_outdir?

[csharp, 2012-05-14 12:49:49]

On 2012/05/14 01:40:15, Marc-Antoine Ruel wrote:
> Chris, what do you think about this? Then we could override this value in
> chromium.swarm to remove the need to do an additional copy.
> 
> I'm still unsatisfied about tests_run and tests_outdir. Maybe isolate_mode and
> isolate_outdir?

Sounds like a good idea to me.  Is it just the hashtable values that will go to
the output directory? If so maybe a good name for it would be hashtable_outdir?

[M-A Ruel, 2012-05-14 13:27:47]

On 2012/05/14 12:49:49, csharp wrote:
> On 2012/05/14 01:40:15, Marc-Antoine Ruel wrote:
> > Chris, what do you think about this? Then we could override this value in
> > chromium.swarm to remove the need to do an additional copy.
> > 
> > I'm still unsatisfied about tests_run and tests_outdir. Maybe isolate_mode
and
> > isolate_outdir?
> 
> Sounds like a good idea to me.  Is it just the hashtable values that will go
to
> the output directory? If so maybe a good name for it would be
hashtable_outdir?

--outdir is also used for remap. It is ignored for the other modes. So I'm not
100% sure about using 'hashtable' in the variable name.

A new day, a new opinion, I'm thinking about using something longer and more
explicit, like test_isolation_mode and test_isolation_outdir. Opinion?

[MAD, 2012-05-14 21:51:08]

LGTM

I think it's fine as is... Unless you think that these outdirs would eventually
be something else than the outdirs of the tests (i.e., the product dir), than I
think they should simply stay tests_dir (if this was what you were asking for as
an opinion)... :-)

BYE
MAD...

[M-A Ruel, 2012-05-15 02:35:52]

I'll keep on using test_isolation_foo, I 'think' it is a better name.

[commit-bot: I haz the power, 2012-05-15 14:55:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10392073/6002

[commit-bot: I haz the power, 2012-05-15 14:56:35]

Change committed as 137127