Socket subsystem implementation

libraries/nacl-mounts/net/TcpSocket.h

+// Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SOCKET_H
+#define SOCKET_H
+
+#include <deque>
+#include <queue>
+#include <vector>
+
+#include "../include/ppapi/cpp/completion_callback.h"
+#include "../include/ppapi/cpp/private/tcp_socket_private.h"
+#include "base/PthreadHelpers.h"
+#include "net/SocketSubSystem.h"
+
+class TCPSocket : public FileStream {
+ public:
+  explicit TCPSocket(SocketSubSystem* sys, int oflag);

[Dmitry Polukhin, 2012/05/29 15:00:51]

explicit is useless if c-tor has more more than 1 argument.

[vissi, 2012/05/30 08:10:51]

I wanted to eliminate lint warning, removed now.

+  virtual ~TCPSocket();
+
+  int oflag() { return oflag_; }
+  bool is_block() { return !(oflag_ & O_NONBLOCK); }
+  bool is_open() { return socket_ != NULL; }
+
+  bool connect(const char* host, uint16_t port);
+  bool acceptFrom(PP_Resource resource);
+
+  virtual void addref();
+  virtual void release();
+
+  virtual void close();
+  virtual int read(char* buf, size_t count, size_t* nread);
+  virtual int write(const char* buf, size_t count, size_t* nwrote);
+
+  virtual int fcntl(int cmd,  va_list ap);
+
+  virtual bool is_read_ready();
+  virtual bool is_write_ready();
+  virtual bool is_exception();
+
+ private:
+  void sendtask();

[Dmitry Polukhin, 2012/05/29 15:00:51]

I think this function should be renamed to SendTask. In general my code need to
be cleaned up to follow Chromium style guide in function naming - perhaps we
need to invent some additional conventions to distinguished function that need
to be called on main thread.

[vissi, 2012/05/30 08:10:51]

This function is not used anywhere, removed now.

+
+  void Connect(int32_t result, const char* host, uint16_t port, int32_t* pres);
+  void OnConnect(int32_t result, int32_t* pres);
+
+  void Read(int32_t result, int32_t* pres);
+  void OnRead(int32_t result, int32_t* pres);
+
+  void Write(int32_t result, int32_t* pres);
+  void OnWrite(int32_t result, int32_t* pres);
+
+  void Close(int32_t result, int32_t* pres);
+
+  bool Accept(int32_t result, PP_Resource resource, int32_t* pres);
+
+  static const size_t kBufSize = 64 * 1024;
+
+  SocketSubSystem* sys;

[Dmitry Polukhin, 2012/05/29 15:00:51]

should end with underscore i.e. sys_

[vissi, 2012/05/30 08:10:51]

Done.

+  int ref_;
+  int oflag_;
+  pp::CompletionCallbackFactory<TCPSocket, ThreadSafeRefCount> factory_;
+  pp::TCPSocketPrivate* socket_;
+  std::deque<char> in_buf_;
+  std::vector<char> out_buf_;
+  std::vector<char> read_buf_;
+  std::vector<char> write_buf_;
+  bool write_sent_;
+
+  DISALLOW_COPY_AND_ASSIGN(TCPSocket);
+};
+
+#endif  // SOCKET_H
+