Issue 10392060: Disable the hang dialog detector when showModalDialog is running.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10392060: Disable the hang dialog detector when showModalDialog is running. (Closed)

Created:
8 years, 7 months ago by Charlie Reis

Modified:
8 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Disable the hang dialog detector when showModalDialog is running. BUG=122153 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136701

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -6 lines)			Patch
M	content/browser/renderer_host/render_view_host_impl.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View	3 chunks	+19 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_impl.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_impl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/common/view_messages.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Charlie Reis

Hi Darin-- This is John's CL (https://chromiumcodereview.appspot.com/10377017/) plus the changes to RenderWidgetHostImpl to avoid depending ...

8 years, 7 months ago (2012-05-11 22:05:27 UTC) #1

LGTM