Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 10392048: Re-land r136486 (reverted in r136500). (Closed)

Created:
8 years, 7 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 7 months ago
Reviewers:
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Re-land r136486 (reverted in r136500). Delete DownloadRateMonitor since it's never worked right. (and it complicates other things I want to do) BUG=73609 TBR=scherkus Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136641

Patch Set 1 #

Patch Set 2 : Fix crashes in Pipeline::Is{Streaming,LocalSource} caused by demuxer_ still being NULL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -650 lines) Patch
D media/base/download_rate_monitor.h View 1 chunk +0 lines, -157 lines 0 comments Download
D media/base/download_rate_monitor.cc View 1 chunk +0 lines, -262 lines 0 comments Download
D media/base/download_rate_monitor_unittest.cc View 1 chunk +0 lines, -165 lines 0 comments Download
M media/base/pipeline.h View 4 chunks +0 lines, -23 lines 0 comments Download
M media/base/pipeline.cc View 1 10 chunks +3 lines, -40 lines 0 comments Download
M media/media.gyp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ami GONE FROM CHROMIUM
Fix crashes in Pipeline::Is{Streaming,LocalSource} caused by demuxer_ still being NULL
8 years, 7 months ago (2012-05-11 16:33:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10392048/2001
8 years, 7 months ago (2012-05-11 16:40:07 UTC) #2
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years, 7 months ago (2012-05-11 17:07:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10392048/2001
8 years, 7 months ago (2012-05-11 17:09:49 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-11 20:00:10 UTC) #5
Change committed as 136641

Powered by Google App Engine
This is Rietveld 408576698