tests/standalone/io/process_environment_test.dart - Issue 10392023: Change dart:io to use Future for one-shot operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/standalone/io/process_environment_test.dart

Issue 10392023: Change dart:io to use Future for one-shot operations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Minor cleanup Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tests/standalone/io/file_test.dart ('K') | « tests/standalone/io/process_check_arguments_test.dart ('k') | tests/standalone/io/process_exit_negative_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/standalone/io/process_environment_test.dart

diff --git a/tests/standalone/io/process_environment_test.dart b/tests/standalone/io/process_environment_test.dart

index 26d5f4b23efa137363aff9dec6daa165dbb5187d..1a2009ee24ea833fbb1da0b9eff3298df6be4675 100644

--- a/tests/standalone/io/process_environment_test.dart

+++ b/tests/standalone/io/process_environment_test.dart

@@ -14,14 +14,10 @@ runEnvironmentProcess(Map environment, name, callback) {

if (!new File(printEnv).existsSync()) {

printEnv = '../$printEnv';

}

- var process = new Process.run(dartExecutable,

- [printEnv, name],

- options,

- (exit, out, err) {

- Expect.equals(0, exit);

- callback(out);

+ Process.run(dartExecutable, [printEnv, name], options).then((result) {

+ Expect.equals(0, result.exitCode);

+ callback(result.stdout);

});

- process.onError = (e) => Expect.fail("Unexpected process start error: '$e'");

}

testEnvironment() {