Change dart:io to use Future for one-shot operations.

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 478 matching lines @@
  * its [TestCase], starting the test process (and first, a compilation
  * process if the TestCase is a [BrowserTestCase]), creating a timeout
  * timer, and recording the results in a new [TestOutput] object, which it
  * attaches to the TestCase.  The lifetime of the RunningProcess is limited
  * to the time it takes to start the process, run the process, and record
  * the result; there are no pointers to it, so it should be available to
  * be garbage collected as soon as it is done.
  */
 class RunningProcess {
   ProcessQueue processQueue;
-  Process process;
+  InteractiveProcess process;
   TestCase testCase;
   bool timedOut = false;
   Date startTime;
   Timer timeoutTimer;
   List<String> stdout;
   List<String> stderr;
   List<Function> handlers;
   bool allowRetries;
 
   /** Which command of [testCase.commands] is currently being executed. */
@@ skipping 87 matching lines @@
   }
 
   void runCommand(Command command,
                   void exitHandler(int exitCode)) {
     if (Platform.operatingSystem == 'windows') {
       // Windows can't handle the first command if it is a .bat file or the like
       // with the slashes going the other direction.
       // TODO(efortuna): Remove this when fixed (Issue 1306).
       command.executable = command.executable.replaceAll('/', '\\');
     }
-    process = new Process.start(command.executable, command.arguments);
+    process = Process.start(command.executable, command.arguments);
     process.onExit = exitHandler;
     process.onError = (e) {
       print("Error starting process:");
       print("  Command: $command");
       print("  Error: $e");
     };
     startTime = new Date.now();
     InputStream stdoutStream = process.stdout;
     InputStream stderrStream = process.stderr;
     StringInputStream stdoutStringStream = new StringInputStream(stdoutStream);
@@ skipping 11 matching lines @@
   void timeoutHandler(Timer unusedTimer) {
     timedOut = true;
     process.kill();
   }
 }
 
 class BatchRunnerProcess {
   String _executable;
   List<String> _batchArguments;
 
-  Process _process;
+  InteractiveProcess _process;
   StringInputStream _stdoutStream;
   StringInputStream _stderrStream;
 
   TestCase _currentTest;
   List<String> _testStdout;
   List<String> _testStderr;
   bool _stdoutDrained = false;
   bool _stderrDrained = false;
   Date _startTime;
   Timer _timer;
@@ skipping 151 matching lines @@
     _process.onExit = (exitCode) {
       _process.close();
       _startProcess(() {
         _reportResult(">>> TEST TIMEOUT");
       });
     };
     _process.kill();
   }
 
   void _startProcess(then) {
-    _process = new Process.start(_executable, _batchArguments);
+    _process = Process.start(_executable, _batchArguments);
     _stdoutStream = new StringInputStream(_process.stdout);
     _stderrStream = new StringInputStream(_process.stderr);
     _testStdout = new List<String>();
     _testStderr = new List<String>();
     _stdoutDrained = false;
     _stderrDrained = false;
     _stdoutStream.onLine = _readStdout(_stdoutStream, _testStdout);
     _stderrStream.onLine = _readStderr(_stderrStream, _testStderr);
     _process.onExit = _exitHandler;
     _process.onError = (e) {
@@ skipping 45 matching lines @@
   /**
    * String indicating the browser used to run the tests. Empty if no browser
    * used.
    */
   String browserUsed = '';
 
   /**
    * Process running the selenium server .jar (only used for Safari and Opera
    * tests.)
    */
-  Process _seleniumServer = null;
+  InteractiveProcess _seleniumServer = null;
 
   /** True if we are in the process of starting the server. */
   bool _startingServer = false;
 
   /** True if we find that there is already a selenium jar running. */
   bool _seleniumAlreadyRunning = false;
 
   ProcessQueue(int this._maxProcesses,
                String progress,
                Date startTime,
@@ skipping 28 matching lines @@
     _checkDone();
   }
 
   String globalTemporaryDirectory() {
     if (_temporaryDirectory != null) return _temporaryDirectory;
 
     if (Platform.operatingSystem == 'windows') {
       throw new Exception(
           'Test suite requires temporary directory. Not supported on Windows.');
     }
-    var tempDir = new Directory('');
-    tempDir.createTempSync();
+    var tempDir = new Directory('').createTempSync();
     _temporaryDirectory = tempDir.path;
     return _temporaryDirectory;
   }
 
   /**
    * Perform any cleanup needed once all tests in a TestSuite have completed
    * and notify our progress indicator that we are done.
    */
   void _cleanupAndMarkDone() {
     if (browserUsed != '' && _seleniumServer != null) {
@@ skipping 54 matching lines @@
     if (!_isSeleniumAvailable && !_startingServer) {
       _startingServer = true;
 
       // Check to see if the jar was already running before the program started.
       String cmd = 'ps';
       var arg = ['aux'];
       if (Platform.operatingSystem == 'windows') {
         cmd = 'tasklist';
         arg.add('/v');
       }
-      Process p = new Process.start(cmd, arg);
+      InteractiveProcess p = Process.start(cmd, arg);
       final StringInputStream stdoutStringStream =
           new StringInputStream(p.stdout);
       p.onError = (e) {
         print("Error starting process:");
         print("  Command: $cmd ${Strings.join(arg, ' ')}");
         print("  Error: $e");
       };
       stdoutStringStream.onLine = () {
         var line = stdoutStringStream.readLine();
         while (null != line) {
@@ skipping 43 matching lines @@
   /**
    * For browser tests using Safari or Opera, we need to use the Selenium 1.0
    * Java server.
    */
   void _startSeleniumServer() {
     // Get the absolute path to the Selenium jar.
     String filePath = new Options().script;
     String pathSep = Platform.pathSeparator;
     int index = filePath.lastIndexOf(pathSep);
     filePath = filePath.substring(0, index) + '${pathSep}testing${pathSep}';
-    var dir = new Directory(filePath);
-    dir.onFile = (String file) {
+    var lister = new Directory(filePath).list();
+    lister.onFile = (String file) {
       if (const RegExp(@"selenium-server-standalone-.*\.jar").hasMatch(file)
           && _seleniumServer == null) {
-        _seleniumServer = new Process.start('java', ['-jar', file]);
+        _seleniumServer = Process.start('java', ['-jar', file]);
         _seleniumServer.onError = (e) {
           print("Error starting process:");
           print("  Command: java -jar $file");
           print("  Error: $e");
         };
         // Heads up: there seems to an obscure data race of some form in
         // the VM between launching the server process and launching the test
         // tasks that disappears when you read IO (which is convenient, since
         // that is our condition for knowing that the server is ready).
         StringInputStream stdoutStringStream =
             new StringInputStream(_seleniumServer.stdout);
         StringInputStream stderrStringStream =
             new StringInputStream(_seleniumServer.stderr);
         stdoutStringStream.onLine =
             makeSeleniumServerHandler(stdoutStringStream);
         stderrStringStream.onLine =
             makeSeleniumServerHandler(stderrStringStream);
       }
     };
-    dir.list();
   }
 
   void _terminateBatchRunners() {
     for (var runners in _batchProcesses.getValues()) {
       for (var runner in runners) {
         runner.terminate();
       }
     }
   }
 
@@ skipping 61 matching lines @@
         // the developer doesn't waste his or her time trying to fix a bunch of
         // tests that appear to be broken but were actually just flakes that
         // didn't get retried because there had already been one failure.
         bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
         new RunningProcess(test, allowRetry, this).start();
       }
       _numProcesses++;
     }
   }
 }