Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10392018: remove WEBKIT_USING_CG (Closed)

Created:
8 years, 7 months ago by jamesr
Modified:
8 years, 7 months ago
CC:
chromium-reviews, jam, dcheng, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

remove WEBKIT_USING_CG We haven't set WEBKIT_USING_CG for several stable releases and do not intend to set it again in the forseeable future. This deletes the now-dead code BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -184 lines) Patch
M chrome/renderer/webview_color_overlay.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -7 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M ppapi/shared_impl/private/ppb_browser_font_trusted_shared.cc View 1 chunk +1 line, -9 lines 0 comments Download
M ppapi/shared_impl/private/ppb_font_shared.cc View 1 chunk +1 line, -9 lines 0 comments Download
M webkit/glue/image_decoder.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M webkit/glue/webclipboard_impl.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M webkit/glue/webcursor.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M webkit/glue/webkit_glue.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M webkit/media/webmediaplayer_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/media/webmediaplayer_impl.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M webkit/plugins/sad_plugin.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M webkit/plugins/webview_plugin.cc View 3 chunks +1 line, -16 lines 0 comments Download
M webkit/tools/test_shell/mock_webclipboard_impl.cc View 3 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
Brett! You are the winner of this lovely code deletion CL (since I need a ...
8 years, 7 months ago (2012-05-09 22:18:56 UTC) #1
scherkus (not reviewing)
AMAZING \o/ (FWIW webkit/media/ LGTM)
8 years, 7 months ago (2012-05-09 22:35:21 UTC) #2
darin (slow to review)
LGTM
8 years, 7 months ago (2012-05-10 08:27:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10392018/1
8 years, 7 months ago (2012-05-10 18:12:43 UTC) #4
commit-bot: I haz the power
Presubmit check for 10392018-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-10 18:13:11 UTC) #5
brettw
ppapi lgtm
8 years, 7 months ago (2012-05-10 18:20:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10392018/1
8 years, 7 months ago (2012-05-10 18:21:12 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-05-10 20:08:26 UTC) #8 
Change committed as 136369

Powered by Google App Engine
This is Rietveld 408576698