tools/json_schema_compiler/cc_generator.py - Issue 10392008: Move declarative API into events API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/cc_generator.py

Issue 10392008: Move declarative API into events API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Extend apiDefinitions.GetExtensionAPIDefinition to return individual apis Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/cc_generator.py

diff --git a/tools/json_schema_compiler/cc_generator.py b/tools/json_schema_compiler/cc_generator.py

index 3efad841e48abb226715dd04c18944d1d9bfc1d8..b234ab05d3903b41731b9a193c91b40af800c546 100644

--- a/tools/json_schema_compiler/cc_generator.py

+++ b/tools/json_schema_compiler/cc_generator.py

@@ -99,12 +99,6 @@ class CCGenerator(object):

c = Code()

if type_.functions:

- # Types with functions are not instantiable in C++ because they are

- # handled in pure Javascript and hence have no properties or

- # additionalProperties.

- if type_.properties:

- raise NotImplementedError('\n'.join(model.GetModelHierarchy(type_)) +

- '\nCannot generate both functions and properties on a type')

for function in type_.functions.values():

(c.Concat(

self._GenerateFunction(