Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3977)

Unified Diff: chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js

Issue 10392008: Move declarative API into events API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js b/chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js
index 9ae24cc69f7238729a7c8f37398411cd7f9d76a1..21416bd59d264f515a34b6e8e25a249657fb0409 100644
--- a/chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js
@@ -9,10 +9,9 @@ var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
chromeHidden.registerCustomHook('declarativeWebRequest', function(api) {
// Returns the schema definition of type |typeId| defined in |namespace|.
function getSchema(namespace, typeId) {
- var filterNamespace = function(val) {return val.namespace === namespace;};
- var apiSchema = api.apiDefinitions.filter(filterNamespace)[0];
- var filterTypeId = function (val) {return val.id === typeId;};
- var resultSchema = apiSchema.types.filter(filterTypeId)[0];
+ var apiSchema = chromeHidden.lookup(api.apiDefinitions,
+ 'namespace', namespace);
not at google - send to devlin 2012/05/10 09:01:25 nit: arguments should line up, but this could be
battre 2012/05/10 16:40:29 Done.
+ var resultSchema = chromeHidden.lookup(apiSchema.types, 'id', typeId);
return resultSchema;
}

Powered by Google App Engine
This is Rietveld 408576698