src/trusted/service_runtime/nacl_syscall_hook.c - Issue 10392005: Thread suspension: Implement for Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/service_runtime/nacl_syscall_hook.c

Issue 10392005: Thread suspension: Implement for Linux (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Comment about docs Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/trusted/service_runtime/nacl_syscall_hook.c

diff --git a/src/trusted/service_runtime/nacl_syscall_hook.c b/src/trusted/service_runtime/nacl_syscall_hook.c

index 5b4bde16d532c219245b860f30b291bc7b4456fc..7d19d635e4240966bdc36d8741293d690b756e80 100644

--- a/src/trusted/service_runtime/nacl_syscall_hook.c

+++ b/src/trusted/service_runtime/nacl_syscall_hook.c

@@ -162,7 +162,7 @@ NORETURN void NaClSyscallCSegHook(int32_t tls_idx) {

* After this NaClAppThreadSetSuspendState() call, we should not

* claim any mutexes, otherwise we risk deadlock. Note that if

* NACLVERBOSITY is set high enough to enable the NaClLog() calls in

- * NaClSwitchToApp(), these calls could deadlock on Windows.

+ * NaClSwitchToApp(), these calls could deadlock.

NaClAppThreadSetSuspendState(natp, NACL_APP_THREAD_TRUSTED,

NACL_APP_THREAD_UNTRUSTED);