Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 10391196: Fix a DomStorageEvent bug with reporting the wrong connection_id to renderers. (Closed)

Created:
8 years, 7 months ago by michaeln
Modified:
8 years, 7 months ago
Reviewers:
dgrogan, jsbell
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Fix a DomStorageEvent bug with reporting the wrong connection_id to renderers and avoid sending session storage events across process boundaries. BUG=128482 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137985

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M content/browser/dom_storage/dom_storage_message_filter.cc View 1 7 chunks +22 lines, -5 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
michaeln
hi david, can you take a look at this one? http://codereview.chromium.org/10391196/diff/4004/content/browser/dom_storage/dom_storage_message_filter.cc File content/browser/dom_storage/dom_storage_message_filter.cc (left): http://codereview.chromium.org/10391196/diff/4004/content/browser/dom_storage/dom_storage_message_filter.cc#oldcode82 ...
8 years, 7 months ago (2012-05-18 01:42:34 UTC) #1
michaeln
https://chromiumcodereview.appspot.com/10391196/diff/4004/content/browser/dom_storage/dom_storage_message_filter.cc File content/browser/dom_storage/dom_storage_message_filter.cc (left): https://chromiumcodereview.appspot.com/10391196/diff/4004/content/browser/dom_storage/dom_storage_message_filter.cc#oldcode82 content/browser/dom_storage/dom_storage_message_filter.cc:82: int connection_id = IPC::MessageIterator(message).NextInt(); On 2012/05/18 01:42:34, michaeln wrote: ...
8 years, 7 months ago (2012-05-18 20:18:11 UTC) #2
michaeln
hi josh, since david's out can you take a look?
8 years, 7 months ago (2012-05-18 21:54:29 UTC) #3
jsbell
8 years, 7 months ago (2012-05-18 22:08:58 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698