Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 10391187: Merge 137535 - Fix incorrect forcing of text directionality in canvas_skia.cc. (Closed)

Created:
8 years, 7 months ago by Alexei Svitkine (slow)
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 137535 - Fix incorrect forcing of text directionality in canvas_skia.cc. There were two issues: 1. RTL wrapping was simply not happening if your UI language locale was not RTL. Which made FORCE_RTL_DIRECTIONALITY not work. 2. RTL wrapping was not being applied in the SizeStringInt() path, which resulted in an inconsistency between the needed width for SizeStringInt() and DrawStringInt(), causing a problem with the label code resulting in truncation. This CL fixes both issues. BUG=128073, 105550 TEST=See testcases attached to bug. Review URL: https://chromiumcodereview.appspot.com/10384168 TBR=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -16 lines) Patch
M ui/gfx/canvas_skia.cc View 6 chunks +40 lines, -16 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Alexei Svitkine (slow)
8 years, 7 months ago (2012-05-17 18:49:43 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698