Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 10391185: Removing FileUtilities::revealOSInFolder which is not used anymore (Closed)

Created:
8 years, 7 months ago by kinuko
Modified:
8 years, 7 months ago
Reviewers:
tony, Avi (use Gerrit), jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Removing FileUtilities::revealOSInFolder which is not used anymore BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138079

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -32 lines) Patch
M content/browser/renderer_host/file_utilities_message_filter.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/file_utilities_message_filter.cc View 1 4 chunks +1 line, -12 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/common/file_utilities_messages.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 chunks +0 lines, -10 lines 0 comments Download
M webkit/glue/webfileutilities_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/webfileutilities_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kinuko
The method is not used any more. I'm going to remove WebKit's ones once we ...
8 years, 7 months ago (2012-05-18 06:18:42 UTC) #1
jam
switching reviewers to avi, who just moved this :) see http://codereview.chromium.org/10323002/
8 years, 7 months ago (2012-05-18 16:34:08 UTC) #2
Avi (use Gerrit)
hahahahahaha LGTM Does this show that I didn't actually test my change? :)
8 years, 7 months ago (2012-05-18 16:39:32 UTC) #3
tony
LGTM
8 years, 7 months ago (2012-05-18 17:13:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/10391185/1
8 years, 7 months ago (2012-05-21 02:27:52 UTC) #5
commit-bot: I haz the power
Failed to apply patch for content/browser/renderer_host/render_process_host_impl.cc: While running patch -p1 --forward --force; patching file content/browser/renderer_host/render_process_host_impl.cc ...
8 years, 7 months ago (2012-05-21 02:28:03 UTC) #6
Avi (use Gerrit)
Right, because I just moved this function, as John noted, in http://codereview.chromium.org/10323002/ .
8 years, 7 months ago (2012-05-21 02:29:17 UTC) #7
kinuko
On 2012/05/21 02:29:17, Avi wrote: > Right, because I just moved this function, as John ...
8 years, 7 months ago (2012-05-21 02:30:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/10391185/10001
8 years, 7 months ago (2012-05-21 04:16:04 UTC) #9
commit-bot: I haz the power
8 years, 7 months ago (2012-05-21 05:42:04 UTC) #10
Change committed as 138079

Powered by Google App Engine
This is Rietveld 408576698