Issue 10391182: Fixed proxy settings button behaviour: it becomes disabled when device isn't connected to any netwo…

Issue 10391182: Fixed proxy settings button behaviour: it becomes disabled when device isn't connected to any netwo… (Closed)

Created:
8 years, 7 months ago by ygorshenin1

Modified:
8 years, 7 months ago

Reviewers:
sadrul, Ben Goodger (Google)

CC:
chromium-reviews, stevenjb+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, ben+watch_chromium.org, Nikita (slow)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fixed proxy settings button behaviour: it becomes disabled when device isn't connected to any network. BUG=chromium:124943 TEST=Manual testing on an Alex device. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137915

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix, sync. #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
M	ash/shell.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ash/system/network/tray_network.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/system/tray/system_tray_delegate.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/system/ash_system_tray_delegate.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

sadrul

LGTM with the nit addressed. http://codereview.chromium.org/10391182/diff/1/ash/system/tray/system_tray_delegate.h File ash/system/tray/system_tray_delegate.h (right): http://codereview.chromium.org/10391182/diff/1/ash/system/tray/system_tray_delegate.h#newcode256 ash/system/tray/system_tray_delegate.h:256: // Returns whether we ...

8 years, 7 months ago (2012-05-17 20:03:00 UTC) #2

ygorshenin1

Thanks! http://codereview.chromium.org/10391182/diff/1/ash/system/tray/system_tray_delegate.h File ash/system/tray/system_tray_delegate.h (right): http://codereview.chromium.org/10391182/diff/1/ash/system/tray/system_tray_delegate.h#newcode256 ash/system/tray/system_tray_delegate.h:256: // Returns whether we conneted to any network. ...

8 years, 7 months ago (2012-05-18 11:19:19 UTC) #3

ygorshenin1

On 2012/05/18 15:57:31, Ben Goodger (Google) wrote: > lgtm Thanks!

8 years, 7 months ago (2012-05-18 17:21:39 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/10391182/8001

8 years, 7 months ago (2012-05-18 17:25:26 UTC) #7

Change committed as 137915

Expand Messages | Collapse Messages