1. Enable large object pointer offset check in release build.

base/allocator/allocator.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'jemalloc_dir': '../../third_party/jemalloc/chromium',
     'tcmalloc_dir': '../../third_party/tcmalloc/chromium',
   },
   'targets': [
@@ skipping 183 matching lines @@
         # jemalloc files
         '<(jemalloc_dir)/jemalloc.c',
         '<(jemalloc_dir)/jemalloc.h',
         '<(jemalloc_dir)/ql.h',
         '<(jemalloc_dir)/qr.h',
         '<(jemalloc_dir)/rb.h',
 
         'allocator_shim.cc',
         'allocator_shim.h',
         'generic_allocators.cc',
-        'win_allocator.cc',        
+        'win_allocator.cc',
       ],
       # sources! means that these are not compiled directly.
       'sources!': [
         # Included by allocator_shim.cc for maximal inlining.
         'generic_allocators.cc',
         'win_allocator.cc',
 
         # We simply don't use these, but list them above so that IDE
         # users can view the full available source for reference, etc.
         '<(tcmalloc_dir)/src/addressmap-inl.h',
@@ skipping 205 matching lines @@
             '<(tcmalloc_dir)/src/heap-checker-bcad.cc',
             '<(tcmalloc_dir)/src/heap-checker.cc',
           ],
           # Disable the heap checker in tcmalloc.
           'defines': [
             'NO_HEAP_CHECK',
           ],
         }],
       ],
     },
+

[jar (doing other things), 2012/05/17 01:36:41]

nit: remove line.

[kaiwang, 2012/05/19 00:12:27]

Done.

     {
-      # This library is linked in to libbase and allocator_unittests.
-      # It can't depend on either and nothing else should depend on it -
+      # This library is linked in to libbase, allocator_unittests and TCMalloc
+      # tests. It can't depend on either and nothing else should depend on it -
       # all other code should use the interfaced provided by libbase.
       'target_name': 'allocator_extension_thunks',
       'type': 'static_library',
       'sources': [
         'allocator_extension_thunks.cc',
         'allocator_extension_thunks.h',
       ],
       'toolsets': ['host', 'target'],
       'include_dirs': [
         '../../'
@@ skipping 53 matching lines @@
           'toolsets': ['host', 'target'],
           'include_dirs': [
             '../../'
           ],
           'configurations': {
             'Common_Base': {
               'msvs_target_platform': 'x64',
             },
           },
         },
+      {
+        'target_name': 'tcmalloc_free_check_test',
+        'type': 'executable',
+        'sources': [
+          'tcmalloc_free_check_test.cc',
+
+          # Part of chromium code(instead of TCMalloc). We don't include the
+          # TCMalloc version(atomicops-internals-x86.cc) in allocator library,
+          # so need this for replacement.
+          '../atomicops_internals_x86_gcc.cc',
+
+          # Code allocator_shim.cc depends on.
+          '../profiler/alternate_timer.cc',
+          '../profiler/alternate_timer.h',
+        ],
+        'include_dirs': [
+          '../..',
+
+          # This is tricky.. We add this include dir so alternate_timer.cc will

[jar (doing other things), 2012/05/17 01:36:41]

I'd suggest asking rvargas about this and be sure he's fine with it.

[kaiwang, 2012/05/19 00:12:27]

Will add as a reviewer

+          # use TCMalloc's logging.h, instead of the intuitional chromium

[jar (doing other things), 2012/05/17 01:36:41]

nit: delete "intuitional"

[kaiwang, 2012/05/19 00:12:27]

Done.

+          # base/logging.h as in other building targets.

[jar (doing other things), 2012/05/17 01:36:41]

nit: building-->build

[kaiwang, 2012/05/19 00:12:27]

Done.

+          '<(tcmalloc_dir)/src',
+        ],
+        'dependencies': [
+          'allocator',
+          'allocator_extension_thunks',
+          '../../testing/gtest.gyp:gtest',
+        ],
+      },
       ],
     }],
   ],
 }