Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: build/android/single_test_runner.py

Issue 10391172: Fix test filter filename for APK based tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed the if-else logic from single_test_runner Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/test_package_apk.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/single_test_runner.py
diff --git a/build/android/single_test_runner.py b/build/android/single_test_runner.py
index 503088cdfb035122b45484ac4f78c80a336f9c8b..35f14369fbab56a216682810dc91cb6991a95d0b 100644
--- a/build/android/single_test_runner.py
+++ b/build/android/single_test_runner.py
@@ -75,18 +75,14 @@ class SingleTestRunner(BaseTestRunner):
def _GetFilterFileName(self):
"""Returns the filename of gtest filter."""
- filter_dir = os.path.join(sys.path[0], 'gtest_filter')
- filter_name = self.test_package.test_suite_basename + '_disabled'
- disabled_filter = os.path.join(filter_dir, filter_name)
- return disabled_filter
+ return os.path.join(sys.path[0], 'gtest_filter',
+ self.test_package.GetDisabledTestsBaseFileName() + '_disabled')
def _GetAdditionalEmulatorFilterName(self):
"""Returns the filename of additional gtest filter for emulator."""
- filter_dir = os.path.join(sys.path[0], 'gtest_filter')
- filter_name = '%s%s' % (self.test_package.test_suite_basename,
+ return os.path.join(sys.path[0], 'gtest_filter',
+ self.test_package.GetDisabledTestsBaseFileName() +
'_emulator_additional_disabled')
- disabled_filter = os.path.join(filter_dir, filter_name)
- return disabled_filter
def GetDisabledTests(self):
"""Returns a list of disabled tests.
« no previous file with comments | « no previous file | build/android/test_package_apk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698