Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: build/android/single_test_runner.py

Issue 10391172: Fix test filter filename for APK based tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed the if-else logic from single_test_runner Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | build/android/test_package_apk.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import logging 5 import logging
6 import os 6 import os
7 import sys 7 import sys
8 8
9 from base_test_runner import BaseTestRunner 9 from base_test_runner import BaseTestRunner
10 import debug_info 10 import debug_info
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 def _TestSuiteRequiresMockTestServer(self): 68 def _TestSuiteRequiresMockTestServer(self):
69 """Returns True if the test suite requires mock test server.""" 69 """Returns True if the test suite requires mock test server."""
70 return False 70 return False
71 # TODO(yfriedman): Disabled because of flakiness. 71 # TODO(yfriedman): Disabled because of flakiness.
72 # (self.test_package.test_suite_basename == 'unit_tests' or 72 # (self.test_package.test_suite_basename == 'unit_tests' or
73 # self.test_package.test_suite_basename == 'net_unittests' or 73 # self.test_package.test_suite_basename == 'net_unittests' or
74 # False) 74 # False)
75 75
76 def _GetFilterFileName(self): 76 def _GetFilterFileName(self):
77 """Returns the filename of gtest filter.""" 77 """Returns the filename of gtest filter."""
78 filter_dir = os.path.join(sys.path[0], 'gtest_filter') 78 return os.path.join(sys.path[0], 'gtest_filter',
79 filter_name = self.test_package.test_suite_basename + '_disabled' 79 self.test_package.GetDisabledTestsBaseFileName() + '_disabled')
80 disabled_filter = os.path.join(filter_dir, filter_name)
81 return disabled_filter
82 80
83 def _GetAdditionalEmulatorFilterName(self): 81 def _GetAdditionalEmulatorFilterName(self):
84 """Returns the filename of additional gtest filter for emulator.""" 82 """Returns the filename of additional gtest filter for emulator."""
85 filter_dir = os.path.join(sys.path[0], 'gtest_filter') 83 return os.path.join(sys.path[0], 'gtest_filter',
86 filter_name = '%s%s' % (self.test_package.test_suite_basename, 84 self.test_package.GetDisabledTestsBaseFileName() +
87 '_emulator_additional_disabled') 85 '_emulator_additional_disabled')
88 disabled_filter = os.path.join(filter_dir, filter_name)
89 return disabled_filter
90 86
91 def GetDisabledTests(self): 87 def GetDisabledTests(self):
92 """Returns a list of disabled tests. 88 """Returns a list of disabled tests.
93 89
94 Returns: 90 Returns:
95 A list of disabled tests obtained from gtest_filter/test_suite_disabled. 91 A list of disabled tests obtained from gtest_filter/test_suite_disabled.
96 """ 92 """
97 disabled_tests = run_tests_helper.GetExpectations(self._GetFilterFileName()) 93 disabled_tests = run_tests_helper.GetExpectations(self._GetFilterFileName())
98 if self._running_on_emulator: 94 if self._running_on_emulator:
99 # Append emulator's filter file. 95 # Append emulator's filter file.
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 def TearDown(self): 304 def TearDown(self):
309 """Cleans up the test enviroment for the test suite.""" 305 """Cleans up the test enviroment for the test suite."""
310 self.test_package.tool.CleanUpEnvironment() 306 self.test_package.tool.CleanUpEnvironment()
311 if self.test_package.cleanup_test_files: 307 if self.test_package.cleanup_test_files:
312 self.adb.RemovePushedFiles() 308 self.adb.RemovePushedFiles()
313 if self.dump_debug_info: 309 if self.dump_debug_info:
314 self.dump_debug_info.StopRecordingLog() 310 self.dump_debug_info.StopRecordingLog()
315 if self.test_package.performance_test: 311 if self.test_package.performance_test:
316 self.adb.TearDownPerformanceTest() 312 self.adb.TearDownPerformanceTest()
317 super(SingleTestRunner, self).TearDown() 313 super(SingleTestRunner, self).TearDown()
OLDNEW
« no previous file with comments | « no previous file | build/android/test_package_apk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698