Fix test filter filename for APK based tests.

Fix test filter filename for APK based tests.

BUG=125059
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137614

[Yaron, 2012-05-16 21:23:54]

http://codereview.chromium.org/10391172/diff/1/build/android/single_test_runn...
File build/android/single_test_runner.py (right):

http://codereview.chromium.org/10391172/diff/1/build/android/single_test_runn...
build/android/single_test_runner.py:51: self._apk_test_suite = True;
This violates the point of having TestPackage and sub-classing with
TestPackageApk  and TestPackageExecutable. You should just add a helper function
and implement for TestPackageAPk

[John Grabowski, 2012-05-16 22:24:17]

http://codereview.chromium.org/10391172/diff/1/build/android/single_test_runn...
File build/android/single_test_runner.py (right):

http://codereview.chromium.org/10391172/diff/1/build/android/single_test_runn...
build/android/single_test_runner.py:51: self._apk_test_suite = True;
On 2012/05/16 21:23:55, Yaron wrote:
> This violates the point of having TestPackage and sub-classing with
> TestPackageApk  and TestPackageExecutable. You should just add a helper
function
> and implement for TestPackageAPk

agree.  E.g. use FilterName() as an overridable method.

http://codereview.chromium.org/10391172/diff/1/build/android/single_test_runn...
build/android/single_test_runner.py:82: if self._apk_test_suite:
Staging/transition makes for odd choices.
In the future, we'll only use the apk.
For now, we have both.

One option is to use the non-apk version as a "default", then have +test and
-test addition/subtraction.  That'll help keep things clean.  But may not be
worth your time.

[nilesh, 2012-05-16 22:36:54]

PTAL.

http://codereview.chromium.org/10391172/diff/1/build/android/single_test_runn...
File build/android/single_test_runner.py (right):

http://codereview.chromium.org/10391172/diff/1/build/android/single_test_runn...
build/android/single_test_runner.py:51: self._apk_test_suite = True;
On 2012/05/16 22:24:17, John Grabowski wrote:
> On 2012/05/16 21:23:55, Yaron wrote:
> > This violates the point of having TestPackage and sub-classing with
> > TestPackageApk  and TestPackageExecutable. You should just add a helper
> function
> > and implement for TestPackageAPk
> 
> agree.  E.g. use FilterName() as an overridable method.
> 

Done.

[John Grabowski, 2012-05-16 23:29:39]

LGTM!

[commit-bot: I haz the power, 2012-05-17 00:45:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10391172/6001

[commit-bot: I haz the power, 2012-05-17 02:10:01]

Change committed as 137614