Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: vm/flow_graph_builder.cc

Issue 10391171: Remove an unused input operand from ExtractConstructorInstantiator. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/flow_graph_builder.cc
===================================================================
--- vm/flow_graph_builder.cc (revision 7699)
+++ vm/flow_graph_builder.cc (working copy)
@@ -1544,7 +1544,7 @@
// The type arguments are uninstantiated. The generated pseudo code:
// t1 = InstantiatorTypeArguments();
// t2 = ExtractConstructorTypeArguments(t1);
- // t1 = ExtractConstructorInstantiator(t1, t2);
+ // t1 = ExtractConstructorInstantiator(t1);
// t_n <- t2
// t_n+1 <- t1
// Use expression_temp_var and node->allocated_object_var() locals to keep
@@ -1573,14 +1573,11 @@
// t2: extracted constructor type arguments.
Definition* load_instantiator = new BindInstr(BuildLoadLocal(t1));
AddInstruction(load_instantiator);
- Definition* load_type_arguments = new BindInstr(BuildLoadLocal(t2));
- AddInstruction(load_type_arguments);
BindInstr* extract_instantiator =
new BindInstr(new ExtractConstructorInstantiatorComp(
node,
- new UseVal(load_instantiator),
- new UseVal(load_type_arguments)));
+ new UseVal(load_instantiator)));
AddInstruction(extract_instantiator);
AddInstruction(new DoInstr(
BuildStoreLocal(t1, new UseVal(extract_instantiator))));
« no previous file with comments | « no previous file | vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698