Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 10391170: Add RequestUpdate to NetworkSmsHandler (Closed)

Created:
8 years, 7 months ago by stevenjb
Modified:
8 years, 7 months ago
Reviewers:
hashimoto, satorux1
CC:
chromium-reviews
Visibility:
Public.

Description

Add RequestUpdate to NetworkSmsHandler BUG=124269 TEST=None yet, except that tests pass; will be used for further testing. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137507

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : Address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -10 lines) Patch
M chromeos/dbus/gsm_sms_client.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chromeos/dbus/gsm_sms_client.cc View 1 3 chunks +25 lines, -10 lines 0 comments Download
M chromeos/dbus/mock_gsm_sms_client.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/network/network_sms_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/network/network_sms_handler.cc View 1 2 3 chunks +14 lines, -0 lines 0 comments Download
M chromeos/network/network_sms_handler_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
stevenjb
Small addition for testing the UI with the stub (so that no fake SMS messages ...
8 years, 7 months ago (2012-05-16 20:53:09 UTC) #1
satorux1
LGTM http://codereview.chromium.org/10391170/diff/3007/chromeos/network/network_sms_handler.cc File chromeos/network/network_sms_handler.cc (right): http://codereview.chromium.org/10391170/diff/3007/chromeos/network/network_sms_handler.cc#newcode164 chromeos/network/network_sms_handler.cc:164: (*iter)->RequestUpdate(); nit: add {} ? If I understand ...
8 years, 7 months ago (2012-05-16 20:59:10 UTC) #2
stevenjb
8 years, 7 months ago (2012-05-16 21:12:13 UTC) #3
http://codereview.chromium.org/10391170/diff/3007/chromeos/network/network_sm...
File chromeos/network/network_sms_handler.cc (right):

http://codereview.chromium.org/10391170/diff/3007/chromeos/network/network_sm...
chromeos/network/network_sms_handler.cc:164: (*iter)->RequestUpdate();
On 2012/05/16 20:59:10, satorux1 wrote:
> nit: add {} ? If I understand right, we omit {} only if the conditional and
the
> body are both one line.

Done.

Powered by Google App Engine
This is Rietveld 408576698