Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 10391166: roll gyp 1377:1381 (Closed)

Created:
8 years, 7 months ago by scottmg
Modified:
8 years, 7 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, Nico
Visibility:
Public.

Description

roll gyp 1377:1381 r1378 | Two overflows when many actions are in one target/one script. r1379 | msvs: error out on actions w/o inputs r1380 | ninja: Change the default target from 'build everything' to 'build target "all"'. r1381 | msvs: fix regression in r1378, environment not set up properly for multiple actions on one input TBR=grt@chromium.org BUG=gyp:261 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137586

Patch Set 1 #

Patch Set 2 : 1379 #

Patch Set 3 : 1381 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
8 years, 7 months ago (2012-05-16 18:35:05 UTC) #1
grt (UTC plus 2)
Lgtm On May 16, 2012 2:35 PM, <scottmg@chromium.org> wrote: > Reviewers: grt, > > Description: ...
8 years, 7 months ago (2012-05-16 18:39:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10391166/3001
8 years, 7 months ago (2012-05-16 19:40:18 UTC) #3
commit-bot: I haz the power
Try job failure for 10391166-3001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-16 20:04:24 UTC) #4
scottmg
fyi, bumped rev
8 years, 7 months ago (2012-05-16 22:32:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10391166/6002
8 years, 7 months ago (2012-05-16 22:32:57 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-17 00:47:01 UTC) #7
Change committed as 137586

Powered by Google App Engine
This is Rietveld 408576698