Issue 10391165: Notification for device scale factor change

Issue 10391165: Notification for device scale factor change (Closed)

Created:
8 years, 7 months ago by oshima

Modified:
8 years, 7 months ago

Reviewers:
sky, piman

CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, jochen+watch-content_chromium.org, ben+watch_chromium.org, Ian Vollick, dhollowa+watch_chromium.org, jonathan.backer, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, tfarina, piman+watch_chromium.org, James Su, Fady Samuel

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Notification for device scale factor change BUG=105165 TEST=updated compositor test to cover OnDeviceScaleFactorChagned. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137571

Patch Set 1 #

Patch Set 2 : . #

Total comments: 8

Patch Set 3 : . #

Patch Set 4 : demo_main fix #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -2 lines)			Patch
M	ash/wm/image_grid.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/wm/image_grid.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_aura.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_aura.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/aura/demo/demo_main.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/aura/test/test_window_delegate.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/aura/test/test_window_delegate.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/aura/window.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/aura/window.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/aura/window_delegate.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/compositor/layer.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/compositor/layer_delegate.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/compositor/layer_unittest.cc	View	1	15 chunks	+40 lines, -2 lines	0 comments	Download
M	ui/views/view.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/view.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/widget/native_widget_aura.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/widget/native_widget_aura.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/10391165/diff/1020/ui/aura/test/test_window_delegate.cc File ui/aura/test/test_window_delegate.cc (right): http://codereview.chromium.org/10391165/diff/1020/ui/aura/test/test_window_delegate.cc#newcode72 ui/aura/test/test_window_delegate.cc:72: void TestWindowDelegate::OnDeviceScaleFactorChanged( nit: two spaces http://codereview.chromium.org/10391165/diff/1020/ui/views/view.cc File ui/views/view.cc (right): ...

8 years, 7 months ago (2012-05-16 21:16:01 UTC) #2

piman

The code in compositor/ LGTM. If we need to communicate the change to all views ...

8 years, 7 months ago (2012-05-16 21:44:33 UTC) #3

oshima

8 years, 7 months ago (2012-05-16 21:50:28 UTC) #4

LGTM

Expand Messages | Collapse Messages